Skip to content

Conversation

amerocu
Copy link
Contributor

@amerocu amerocu commented Mar 3, 2019

No description provided.

@hdgarrood
Copy link
Collaborator

Thanks!

@hdgarrood hdgarrood merged commit 13725a0 into purescript:master Mar 7, 2019
@bernhard-herzog
Copy link
Contributor

ISTM that this original type was correct. Before this change, the example in question read:

-- Create an alias for a complex function type
type Baz = Number -> Number -> Bar Number

-- This function will take two arguments and return a record with double the value
mkDoubledFoo :: Baz
mkDoubledFoo foo bar = { foo: 2.0*foo, bar: 2.0*bar }

Baz is defined as a type alias immediately before mkDoubledFoo and is the correct type for that function (Bar is defined earlier in a part I didn't quote here). With this pull request the type becomes Number -> Number -> Baz which is clearly wrong.

@hdgarrood
Copy link
Collaborator

🤦‍♂️ thank you. If someone wants to put a PR together reverting the change I’d appreciate it!

@bernhard-herzog
Copy link
Contributor

I'll prepare one

hdgarrood pushed a commit that referenced this pull request Mar 12, 2019
* Revert "fixed wrong type signature (#245)"

This reverts commit 13725a0.

The type signature that was changed by #245 was actually correct
before that PR, see
#245 (comment)

* Add myself to CONTRIBUTORS.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants