Skip to content

Conversation

kl0tl
Copy link
Member

@kl0tl kl0tl commented Feb 23, 2020

This PR documents the warning that will be emitted for foreign identifiers containing primes once purescript/purescript#3792 is merged.

@hdgarrood
Copy link
Collaborator

Thanks! This is a good start, but I think it could be made clearer, by a) putting a ' in brackets in the "cause" sentence so that it's clearer what a prime character is, like you did in the error message in the compiler repo, and b) showing more explicitly how to update the code to silence the warning, i.e. reproducing the example except without the primes.

@kl0tl kl0tl force-pushed the deprecated-ffi-prime branch from 1cf8e73 to e19e6b1 Compare March 7, 2020 13:50
@kl0tl kl0tl force-pushed the deprecated-ffi-prime branch from e19e6b1 to 513f365 Compare March 7, 2020 13:51
@kl0tl
Copy link
Member Author

kl0tl commented Mar 7, 2020

This looks indeed clearer with your suggestions!

@hdgarrood
Copy link
Collaborator

Looks great 👍

@hdgarrood hdgarrood merged commit c280d68 into purescript:master Mar 7, 2020
@kl0tl kl0tl deleted the deprecated-ffi-prime branch March 7, 2020 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants