Skip to content

batch update and modify functions #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 28, 2017
Merged

Conversation

matthewleon
Copy link
Contributor

Also exports ST utility functions modifySTArray and withArray.

Also exports ST utility functions `modifySTArray` and `withArray`.
Copy link
Contributor

@hdgarrood hdgarrood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have just one tiny comment, but the new additions to the API and the way it has been implemented both look good to me. Thanks!

@@ -71,6 +71,8 @@ module Data.Array
, mapMaybe
, catMaybes
, mapWithIndex
, updateAtIndices
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps put these next to updateAt and modifyAt in the export list, so that when we (I) eventually get around to ordering declarations in HTML docs based on their order of appearance in the export list the docs read better?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@paf31 paf31 merged commit b6c5f5b into purescript:master May 28, 2017
@paf31
Copy link
Contributor

paf31 commented May 28, 2017

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants