add some and many for Lazy List #113
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
safareli
force-pushed
the
somemany
branch
2 times, most recently
from
9245d15 to
51eaed4
Compare
|
Looks good to me 👍 |
paf31
reviewed
Apr 26, 2017
| -- | Attempt a computation multiple times, returning as many successful results | ||
| -- | as possible (possibly zero). | ||
| -- | | ||
| -- | The `Lazy` constraint is used to generate the result lazily, to ensure |
There was a problem hiding this comment.
There is no Lazy constraint here.
There was a problem hiding this comment.
Copied it from List.purs. But even tho Lazy constraint isn't used in many, it's used in some, which is used by many, so it's technically true. If want better wording here please let me know and i'll update it in both places
There was a problem hiding this comment.
Sorry, I misread it, please ignore my comment.
|
Thanks! |
paf31
reviewed
Apr 26, 2017
| -- | The `Lazy` constraint is used to generate the result lazily, to ensure | ||
| -- | termination. | ||
| some :: forall f a. Alternative f => Z.Lazy (f (List a)) => f a -> f (List a) | ||
| some v = cons <$> v <*> Z.defer (\_ -> many v) |
There was a problem hiding this comment.
Is it possible to generate the tail lazily here?
There was a problem hiding this comment.
That's what Z.defer is doing here.
Or do you mean something else?
There was a problem hiding this comment.
Yes, I think this is fine. Sorry again :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #112