make Regex an instance of Show #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yeah, using explicit exports from the module is the way we've been doing this elsewhere. I've thought about local foreign declarations a few times, but I think we don't do it because it interferes with the idea of foreign declarations being imported, and perhaps would be a bit syntactically awkward to deal with too. Any thoughts @paf31? |
|
Okay, this is ready to go. We should continue the language discussion in a PureScript issue. edit: PureScript issue created: purescript/purescript#460 |
|
Thanks 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3.
You probably don't want to merge as is. I was unable to make my foreign function
showRegexPprivate using let bindings. Should I explicitly list the exports in that file instead? Is there a better way?