Add unsafeRegex

[no-longer-on-githu-b]

Fixes #73.

[LiamGoodacre]

👍 Except that usually we separate unsafe functions into sub modules like Data.String.Regex.Unsafe or Data.String.Regex.Partial.

[no-longer-on-githu-b]

Seems reasonable, requires another import though. The goal is mostly to reduce the amount of boilerplate needed for (poor man's) regex literals.

[paf31]

Nitpick: there's no need for the $ here.

[paf31]

Yes, could we please move this into Data.String.Regex.Partial? Looks good otherwise.

[garyb]

Probably should be Data.String.Regex.Unsafe in this case, since there's no partial constraint?

[LiamGoodacre]

Could possibly have a Partial version too/instead.

[garyb]

We already have a Partial version - that's the normal version 😄, this is a convenience to avoid that.

[garyb]

Well, kinda. Having a Partial verison would eliminate the need for fromRight, but that's not really much better.

[LiamGoodacre]

@garyb you mean eliminate the need for unsafePartial, right? The fromRight is what would make this need a Partial constraint.

[garyb]

I meant if we had Partial => String -> RegexFlags -> Regex you'd still end up having to always unsafePartial for the case in the linked issue, so just providing a fully unsafe version is the only way to avoid the annoyance :)

[no-longer-on-githu-b]

Yeah, it's the use of the function we want to make easier, not the definition.

[LiamGoodacre]

@garyb oh you meant: eliminate the need for fromRight on use, not on definition

[no-longer-on-githu-b]

I'll move the function to .Unsafe.

[paf31]

Great, thanks!