Skip to content

Remove Semigroup constraint on monadRecErrorT #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 23, 2015

Conversation

natefaubion
Copy link
Contributor

No description provided.

@natefaubion
Copy link
Contributor Author

The name for the instance in the source is incorrect. Should I address that?

@paf31
Copy link
Contributor

paf31 commented Aug 18, 2015

Yes please :) Also, we can remove the constraint from ErrorT's MonadRec instance too.

@natefaubion
Copy link
Contributor Author

Done

@paf31
Copy link
Contributor

paf31 commented Aug 18, 2015

Hmm, minor bump or major bump? I think minor...

@garyb
Copy link
Member

garyb commented Aug 18, 2015

Yeah, minor I think. Dropping these constraints doesn't change the implications anywhere else.

@paf31
Copy link
Contributor

paf31 commented Aug 18, 2015

I was thinking about the name change, but I think that's ok unless someone was using it from the FFI.

@garyb
Copy link
Member

garyb commented Aug 18, 2015

Ah ok, yeah.

paf31 added a commit that referenced this pull request Aug 23, 2015
Remove Semigroup constraint on monadRecErrorT
@paf31 paf31 merged commit 86f3c5c into purescript:master Aug 23, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants