isValid() with extra token is not working

[Hudda]

We are using pusher ~ 5.1.2 on a AWS lambda function with nodejs version 16.x. When we use webhook.isValid() without any extra-token it works but when we use webhook.isValid(extraTokens) with extra token. It throws an TypeError. Can you please help with the error? We are using typescript.

TypeError: token.verify is not a function

[benw-pusher]

Could you share the code in use (abstracting the tokens, of course)?
You can see the typescript definition at

pusher-http-node/index.d.ts

Line 185 in ba64416

isValid(extraTokens?: Token | Array<Token>): boolean

[Hudda]

We are initializing pusher in constructor

this._pusher = new Pusher({
            appId: app_id,
            key: key,
            secret: secret,
            useTLS: true,
            cluster: cluster,
          });

then a method to check if webhook is valid

validateWebhook(params: Pusher.WebHookRequest): boolean {
    try {
      // Change header keys to lowercase
      params.headers = Object.keys(
        params.headers as { [key: string]: string },
      ).reduce((accumulator: { [key: string]: string }, key) => {
        accumulator[key.toLowerCase()] = (
          params.headers as { [key: string]: string }
        )[key];
        return accumulator;
      }, {});

      const webhook = this._pusher.webhook(params);
      let parsedPusherToken: { key: string; secret: string }[] = [];
      if (this._pusher_list_old_secret) {
        parsedPusherToken = JSON.parse(this._pusher_list_old_secret);
      }
      const isValid = webhook.isValid(parsedPusherToken);
      return isValid;
    } catch (error) {
      throw new PusherError(
        `${InfraErrorMessage.PusherServiceFailed} ${error}`,
      );
    }
  }

then calling this function like this

const isValidWebhook = pusher.validateWebhook({
      headers: event.headers,
      rawBody: event.body || '',
    });

[Hudda]

@benw-pusher any updates?

[Hudda]

@benw-pusher We are stuck because of this problem. Could you please confirm if this is a problem with the pusher library or something to do with our code? Thanks!!

[benw-pusher]

Functionally the library appears to work ok, so this could be a typescript issue only. Is the parsedPusherToken an array, or is it JSON type? The library expects an array, for example

webhook.isValid([
    {key: "newkey", secret: "newsecret"}
  ]) 

[Hudda]

@benw-pusher yes it is an array. I tried both passing it as an array of objects

webhook.isValid([
    {key: "newkey", secret: "newsecret"}
  ]) 

and passing as an object. But it fails everytime.

webhook.isValid(
    {key: "newkey", secret: "newsecret"}
  ) 

[benw-pusher]

Thanks, this looks to be an issue with the Typescript definitions in our library, I'll raise internally to get this addressed

[Hudda]

Thanks @benw-pusher, We are blocked with our implementation due to this error. Any estimation by when would this be fixed? thanks much in advance.

[Hudda]

@benw-pusher any updates? Thanks!!

[Hudda]

@benw-pusher I've created a PR to fix this issue. Could you please take a look? Thanks!!

[Hudda]

@benw-pusher could you please take a look at this PR? We are blocked due to this issue. Thanks!

[Hudda]

@benw-pusher any updates?