Update request dep adjust supported versions #71
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update tests to reflect new requests error type - Add a package-lock file - Update nock version
leesio
force-pushed
the
update-request-dep
branch
2 times, most recently
from
08657c7 to
1608555
Compare
leesio
changed the title
v0.10 and v0.12 are very old now
leesio
force-pushed
the
update-request-dep
branch
from
1608555 to
77cdd8f
Compare
hph
reviewed
Apr 26, 2018
| key: "f00d", | ||
| secret: "beef", | ||
| timeout: 200 | ||
| timeout: 100 |
There was a problem hiding this comment.
Is there a reason for this change? I'm assuming that this change (200 -> 100 and 200 -> 101) doesn't actually affect the result.
There was a problem hiding this comment.
@hph Not really. I think the delay needs to be greater than the timeout now, probably due to the way the requests library now monitors timeouts. I just used a delay 1ms greater than the timeout everywhere.
topliceanu
approved these changes
May 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per #68, #69 and #63