Test versions 3.5 and 3.6 with travis #110
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WillSewell
force-pushed
the
travis-test-newer-python-versions
branch
from
d6d31fe to
59c6e84
Compare
WillSewell
force-pushed
the
travis-test-newer-python-versions
branch
from
59c6e84 to
f4fab06
Compare
|
I'm going to go ahead and merge this. |
|
The tests now seem to be failing, and I'm not sure why. I'm going to revert this branch on master and figure out what the problem is when I have more time. |
|
Ahh sorry @WillSewell, didn't see this the other day 😬 In response to the original question dorpping support sounds like a good idea 👍 Happy to take a look at the test failures with you at some point if that's still an issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original goal of this PR was to test versions 3.5 and 3.6.
However it turned out that the tests fail entirely because the latest version of tornado (a dependency) no longer supports Python 2.6 and 3.3 due to security vulnerabilities. I think this is a strong motivation for dropping support in this library too. For reference, the last Python 2.6 release was 2013-10-29 and the last 3.2 release was 2014-10-12.
Thoughts @callum-oakley?