Skip to content

Commit a659daf

Browse files
tstrukgregkh
authored andcommitted
usb: mon: make mmapped memory read only
Syzbot found an issue in usbmon module, where the user space client can corrupt the monitor's internal memory, causing the usbmon module to crash the kernel with segfault, UAF, etc. The reproducer mmaps the /dev/usbmon memory to user space, and overwrites it with arbitrary data, which causes all kinds of issues. Return an -EPERM error from mon_bin_mmap() if the flag VM_WRTIE is set. Also clear VM_MAYWRITE to make it impossible to change it to writable later. Cc: "Dmitry Vyukov" <dvyukov@google.com> Cc: stable <stable@kernel.org> Fixes: 6f23ee1 ("USB: add binary API to usbmon") Suggested-by: PaX Team <pageexec@freemail.hu> # for the VM_MAYRITE portion Link: https://syzkaller.appspot.com/bug?id=2eb1f35d6525fa4a74d75b4244971e5b1411c95a Reported-by: syzbot+23f57c5ae902429285d7@syzkaller.appspotmail.com Signed-off-by: Tadeusz Struk <tadeusz.struk@linaro.org> Link: https://lore.kernel.org/r/20220919215957.205681-1-tadeusz.struk@linaro.org Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent 5032b26 commit a659daf

File tree

1 file changed

+5
-0
lines changed

1 file changed

+5
-0
lines changed

drivers/usb/mon/mon_bin.c

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1268,6 +1268,11 @@ static int mon_bin_mmap(struct file *filp, struct vm_area_struct *vma)
12681268
{
12691269
/* don't do anything here: "fault" will set up page table entries */
12701270
vma->vm_ops = &mon_bin_vm_ops;
1271+
1272+
if (vma->vm_flags & VM_WRITE)
1273+
return -EPERM;
1274+
1275+
vma->vm_flags &= ~VM_MAYWRITE;
12711276
vma->vm_flags |= VM_DONTEXPAND | VM_DONTDUMP;
12721277
vma->vm_private_data = filp->private_data;
12731278
mon_bin_vma_open(vma);

0 commit comments

Comments
 (0)