Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installing the correct version of FastRTPS for ROS2 #19

Closed
mlautman opened this issue Feb 26, 2019 · 6 comments
Closed

Installing the correct version of FastRTPS for ROS2 #19

mlautman opened this issue Feb 26, 2019 · 6 comments
Labels
documentation Issues regarding documentation (PX4 Devguide; User guide) fix in progress

Comments

@mlautman
Copy link

mlautman commented Feb 26, 2019

The install script for installing eProsima/FastRTPS installs the wrong version of FastRTPS for ROS Bouncy. (1.5.0 instead of 1.6.0) which causes fastrtpsgen to complain that it does not recognize the command line arguement -I when you build the ros2 branch of px4_ros_com.

For ROS2 Bouncy you should install 1.6.0 and for ROS2 Crystal you should install 1.7.0.

@TSC21
Copy link
Member

TSC21 commented Feb 26, 2019

Being addressed on scripts now, but should be simplified so to only get the fastrtpsgen script.

@TSC21 TSC21 added documentation Issues regarding documentation (PX4 Devguide; User guide) fix in progress labels Feb 26, 2019
@tfoote
Copy link

tfoote commented Mar 2, 2019

@TSC21 @LorenzMeier I've been working on a new approach for this with @clalancette that leverages the ROS 2 typesupport packages and is working toward being more generic such that the agent does not have to hard code the topics and types. It works with the binary installed version of fastrtps.

Could you take a look at: https://github.com/osrf/ros2_serial_example We're currently backwards compatible with your implementation but expect to add more features and robustness are planning to evolve the protocol. For example: osrf/ros2_serial_example#18 and add dynamic topic support: osrf/ros2_serial_example#13 instead of just having the yaml file defining the topics as we have now.

@TSC21
Copy link
Member

TSC21 commented Mar 2, 2019

@tfoote really interesting! Could it be something that could back the agent implementation on this package? Meaning a package that is added as a dependency of this package that then subscribes to the uorb data being published after serialized by CDR?

@tfoote
Copy link

tfoote commented Mar 4, 2019

Yes, at the moment it should be a drop in replacement for the agent in this package.

@TSC21
Copy link
Member

TSC21 commented Mar 4, 2019

Alright. I will take a look at it. Thank you

@TSC21
Copy link
Member

TSC21 commented Feb 11, 2020

This is already addressed on the containers and documentation.

@TSC21 TSC21 closed this as completed Feb 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Issues regarding documentation (PX4 Devguide; User guide) fix in progress
Projects
None yet
Development

No branches or pull requests

3 participants