Skip to content

Conversation

choldgraf
Copy link
Contributor

Per some recent conversations on twitter and in the forum, this makes a few small updates:

  • Links the front-page community members section to our dedicated community members page
  • Adds links and a few more steps for getting involved
  • Mentions the bi-weekly meeting
  • Adds a section explaining JOSS and how we relate to it

@lwasser
Copy link
Member

lwasser commented Oct 24, 2019

@choldgraf this is so awesome!! thank you so much for submitting this pr!! i'll merge it unless you'd like me to wait ?! or you can merge it!

@choldgraf
Copy link
Contributor Author

happy w/ whatever! My only question is whether my characterization of JOSS is accurate - I want to make sure they're OK with how we describe them...maybe we should get a JOSS person to give the OK?

@lwasser
Copy link
Member

lwasser commented Oct 24, 2019

ahhh sure @leouieda can you please have a look at this PR and tell us if it captures JOSS properly?

We encourage our reviewers to provide more hands-on assistance and
give more in-depth feedback than is typically required in JOSS. The goal
of pyOpenSci is to ensure that all of its packages meet a minimum level
of best practices and standards, and our review processes often take longer
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@choldgraf the one big difference is pyopensci accepts API wrappers. JOSS does not. so pyopensci accepts MORE packages than JOSS does .

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool - feel free to either make edits directly, or I can make edits when I'm back at home (out of the office hanging out w/ family today)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wonderful. ok i'll make a few edits probably after the meeting. if leo or luiz or lindsay are there, they can help review the language!!! if not i can bug @arfon who might also be willing to look at this PR and ensure we are describing JOSS in the way he'd like us to!!

_pages/home.md Outdated
to improving the visibility and quality of scientific software. They do
so by providing a lightweight review and publishing process so that authors
of packages can publish their packages with a DOI and citable artifact.
They intentionally try to avoid lengthy review and feedback cycles
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure this is quite right. I'd rather see this phrased something like:

"JOSS reviews are limited in scope and the submission criteria less stringent than those of pyOpenSci."

Co-Authored-By: Arfon Smith <arfon@users.noreply.github.com>
@choldgraf
Copy link
Contributor Author

ah this is all super helpful @arfon , thanks very much! I wasn't sure what terminology etc to use in some cases so I appreciate it

@lwasser
Copy link
Member

lwasser commented Oct 24, 2019

i second that !! thank you so much @arfon !!

choldgraf and others added 2 commits October 25, 2019 09:42
Co-Authored-By: Arfon Smith <arfon@users.noreply.github.com>
@choldgraf
Copy link
Contributor Author

OK, accepted the suggestions and updated the language per @arfon's comments. What do folks think now?

@arfon
Copy link
Contributor

arfon commented Oct 25, 2019

LGTM :shipit:

@lwasser
Copy link
Member

lwasser commented Oct 25, 2019

@choldgraf looks good to me too!!! :) i added a small statement about pyopensci accepting API-wrappers. loving @arfon STAMP of approval so stealing it :)

let's merge!! :shipit:

@mbjoseph
Copy link
Member

Agreed - looks good!

@lwasser
Copy link
Member

lwasser commented Oct 25, 2019

ok merging!! :)

@lwasser lwasser merged commit 825d9a2 into pyOpenSci:master Oct 25, 2019

The [Journal of Open Source Software](https://joss.theoj.org/) is a community dedicated
to improving the visibility and quality of scientific software. They do
so by providing a lightweight review and publishing process so that authors

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"lightweight" really minimizes the JOSS review process. I'd hope that JOSS wants reviews to be rigorous so that the journal has a decent reputation. It would be more fair for pyopensci to simply state the differences in the review process and let the reader decide whether one happens to be lightweight or not.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"lightweight" really minimizes the JOSS review process. I'd hope that JOSS wants reviews to be rigorous so that the journal has a decent reputation. It would be more fair for pyopensci to simply state the differences in the review process and let the reader decide whether one happens to be lightweight or not.

Yeah, that's a fair point. I guess I was trying to say lighter weight than pyOpenSci but I see what you mean @moorepants about potentially framing the JOSS review process in a negative light using language like this.

I'd hope that JOSS wants reviews to be rigorous so that the journal has a decent reputation.

💯absolutely.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for noticing this - I agree we definitely don't want to convey the idea that JOSS is a less-than-rigorous review process. Could somebody suggest some better wording that conveys the ideas we want?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would remove "lightweight" as a start.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#27 there's a start - feel free to suggest edits and I'm happy to iterate there

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks guys!! we want everyone to be happy with how we represent our partnership on the website. all feedback is very much appreciated!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants