Skip to content

Fix labeler syntax #1085

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 3, 2022
Merged

Fix labeler syntax #1085

merged 1 commit into from
May 3, 2022

Conversation

@jorgepiloto
Copy link
Member

Progress on #1059.

@jorgepiloto
Copy link
Member Author

Closing and reopening this to trigger the labeler.

@jorgepiloto jorgepiloto reopened this Apr 29, 2022
@codecov
Copy link

codecov bot commented Apr 29, 2022 •
edited
Loading

Codecov Report

Merging #1085 (f75ad0b) into main (d123100) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1085   +/-   ##
=======================================
  Coverage   73.01%   73.01%           
=======================================
  Files          43       43           
  Lines        6381     6381           
=======================================
  Hits         4659     4659           
  Misses       1722     1722

@jorgepiloto
Copy link
Member Author

I'm suspecting about the glob pattern "*", so I finally decided to attack this using another approach.

@jorgepiloto jorgepiloto reopened this Apr 29, 2022
@jorgepiloto jorgepiloto reopened this Apr 29, 2022
@jorgepiloto
Copy link
Member Author

jorgepiloto commented Apr 29, 2022 •
edited
Loading

This is exactly the same syntax we have in ansys-templates:

- name: Test baked project
  if: contains(fromJson('["pybasic", "pyansys"]'), matrix.cfg.template) == false

Which works without problems.

@github-actions github-actions bot added CI/CD Related with CICD, Github Actions, etc Maintenance labels Apr 29, 2022
@github-actions
Copy link
Contributor

Please add one of the following labels to add this contribution to the Release Notes 👇

@jorgepiloto jorgepiloto removed BUG CI/CD Related with CICD, Github Actions, etc labels Apr 29, 2022
@jorgepiloto jorgepiloto reopened this Apr 29, 2022
@jorgepiloto jorgepiloto reopened this Apr 29, 2022
@github-actions github-actions bot added CI/CD Related with CICD, Github Actions, etc Maintenance labels Apr 29, 2022
@github-actions
Copy link
Contributor

Please add one of the following labels to add this contribution to the Release Notes 👇

@jorgepiloto
Copy link
Member Author

This is very weird... If the on: pull_request key is not enabled, GitHub complains about the syntax.

@github-actions
Copy link
Contributor

Please add one of the following labels to add this contribution to the Release Notes 👇

@jorgepiloto jorgepiloto removed BUG CI/CD Related with CICD, Github Actions, etc labels Apr 29, 2022
@jorgepiloto jorgepiloto reopened this Apr 29, 2022
@jorgepiloto jorgepiloto force-pushed the fix/labeler branch 2 times, most recently from 3d0ff18 to 12c50ce Compare April 29, 2022 14:32
@github-actions github-actions bot added CI/CD Related with CICD, Github Actions, etc Maintenance labels Apr 29, 2022
@jorgepiloto jorgepiloto requested a review from germa89 April 29, 2022 14:40
@jorgepiloto
Copy link
Member Author

This is finally working, @germa89.

jorgepiloto
jorgepiloto commented Apr 29, 2022
View reviewed changes
@germa89
Copy link
Collaborator

germa89 commented Apr 29, 2022

Hi @jorgepiloto. This is amazing! Thank you !

germa89
germa89 approved these changes Apr 29, 2022
View reviewed changes
Copy link
Collaborator

@germa89 germa89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice job fixing this issue @jorgepiloto . Thank you very much!

.github/workflows/label.yml
on:
pull_request_target:
types: [opened, reopened]
pull_request:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this is the main change, for functioning. Nice.

@germa89 germa89 merged commit 9879740 into main May 3, 2022
@germa89 germa89 deleted the fix/labeler branch May 3, 2022 09:12
@jorgepiloto jorgepiloto mentioned this pull request May 3, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@germa89 germa89 germa89 approved these changes

Assignees

No one assigned

Labels

CI/CD Related with CICD, Github Actions, etc

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jorgepiloto @germa89