Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync with python_example #5

Merged
merged 3 commits into from
Jun 13, 2016
Merged

Sync with python_example #5

merged 3 commits into from
Jun 13, 2016

Conversation

dean0x7d
Copy link
Member

@dean0x7d dean0x7d commented Jun 11, 2016

As discussed in #4 and pybind/python_example#12, this syncs the example docs, defines version info and adds conda tests.

@SylvainCorlay main.cpp and docs/ are direct copies from python_example with a find and replace for python_example -> cmake_example. I hope that's fine.

Uses CXXFLAGS env variable instead of CMAKE_CXX_FLAGS because
that would clear platform-specific default flags on Windows.
@dean0x7d
Copy link
Member Author

dean0x7d commented Jun 11, 2016

@wjakob I need your assistance to get AppVeyor running again for this repository. The webhooks for pushes and pull requests were lost when the repo was transferred to the pybind org. I recreated the AppVeyor project, but it doesn't install the webhooks since I don't have permission in the repo.

This can be solved in one of the following ways, but I believe you'll need to do it because of the permissions:

  • Either create a new AppVeyor project.
  • Or add the webhooks manually to point to my existing AppVeyor project.

The second one can be done by going into the setting of this repo, then wehooks, add a new one with the url pointing to the existing project. The 'pull request' and 'push' triggers need to be enabled.

Sorry for the trouble.
(There are no such issues on Travis.)

@wjakob
Copy link
Member

wjakob commented Jun 11, 2016

I've made you an admin for the project -- can you change the webhook now?

@dean0x7d
Copy link
Member Author

Cool, I didn't know that was an option.
I configured the webhooks. Everything is back up and running. Thanks!

@dean0x7d dean0x7d changed the title Sync docs with python_example Sync with python_example Jun 12, 2016
@SylvainCorlay
Copy link
Member

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants