Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pybind11 broken with Py_LIMITED_API #1755

Closed
rnburn opened this issue Apr 4, 2019 · 1 comment
Closed

pybind11 broken with Py_LIMITED_API #1755

rnburn opened this issue Apr 4, 2019 · 1 comment

Comments

@rnburn
Copy link

rnburn commented Apr 4, 2019

cast.h uses PyTuple_SET_ITEM but that function i sn't available in the limited api: https://github.com/python/cpython/blob/8ac6539d85b481fc6b5e9145446b07e591b2caba/Include/tupleobject.h#L57-L66

@wjakob
Copy link
Member

wjakob commented Apr 6, 2019

Hi @rnburn,

there are many other functions that pybind11 uses that aren't part of the limited API (and there are no plans to support it).

@wjakob wjakob closed this as completed Apr 6, 2019
copybara-service bot pushed a commit to google/re2 that referenced this issue Sep 7, 2023
This reverts commit 3a9939d.

Reason for revert: pybind11 doesn't support `Py_LIMITED_API`;
as per pybind/pybind11#1755, it has
probably never worked and it will probably never work.

Change-Id: Ie603151d31ad07a77d469f0050270d416fe8d21b
Reviewed-on: https://code-review.googlesource.com/c/re2/+/61872
Reviewed-by: Paul Wankadia <junyer@google.com>
Reviewed-by: Alex Chernyakhovsky <achernya@google.com>
HaoZeke added a commit to HaoZeke/HiGHS that referenced this issue May 5, 2024
Not supported by pybind11, see pybind/pybind11#1755
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants