Minor tweaks to tools/mkdoc.py #1788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recent versions of clang.cindex include [code][1] that converts the internal byte strings to python str for you. [1]: https://github.com/llvm-mirror/clang/blob/master/bindings/python/clang/cindex.py#L72
On some linuxes, /usr/include belongs to GCC and the standard libraries that work with clang are in /usr/lib/clang/8.0.0 or some variation thereof. This results in errors such as: ``` /../lib64/gcc/x86_64-pc-linux-gnu/8.3.0/../../../../include/c++/8.3.0/bits/cxxabi_init_exception.h:38:10: fatal error: 'stddef.h' file not found ``` during extraction.
|
This looks really great! I'm happy with all of these changes. |
|
(The reorganization into small commits was nice, so I rebased your commits rather than squashing them) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains an assortment of minor changes to
tools/mkdoc.pyintended to make it easier to integrate into automated build workflows:-ooption, so the output can be written to a file instead of stderr/usr/lib/clang/8.0.0/include) on Linuxif __name__ == '__main__'and into functions that can be called by other python scripts.Because this is a grab bag of minor tweaks, I've tried to organize the commits so that it's easy to pick and choose -- if there's something I've done here that you don't like, I'm happy to rebase that commit out of the branch.