Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce pybind11::detail::is_move_constructible #4631

Merged
merged 1 commit into from
Apr 24, 2023

Conversation

rwgk
Copy link
Collaborator

@rwgk rwgk commented Apr 21, 2023

Description

To support the use case captured in the new test_vector_unique_ptr_member.cpp

This is very similar to the existing pybind11::detail::is_copy_constructible.

Backport of smart_holder PR #4630 (merged already, after Google global testing).

Suggested changelog entry:

`pybind11::detail::is_move_constructible` can now be specialized for cases in which `std::is_move_constructible` does not work as needed. This is very similar to the long-established `pybind11::detail::is_copy_constructible`.

To support the use case captured in the new test_vector_unique_ptr_member.cpp
@rwgk rwgk marked this pull request as ready for review April 21, 2023 18:34
@rwgk rwgk requested a review from henryiii as a code owner April 21, 2023 18:34
@rwgk
Copy link
Collaborator Author

rwgk commented Apr 24, 2023

Thanks Aaron!

@rwgk rwgk merged commit 07725c2 into pybind:master Apr 24, 2023
@rwgk rwgk deleted the vector_unique_ptr_member_master branch April 24, 2023 07:19
@github-actions github-actions bot added the needs changelog Possibly needs a changelog entry label Apr 24, 2023
rwgk pushed a commit to rwgk/pybind11 that referenced this pull request Apr 27, 2023
@rwgk rwgk removed the needs changelog Possibly needs a changelog entry label May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants