Skip to content

Adds support for writing CSRs. #1963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 19, 2015
Merged

Adds support for writing CSRs. #1963

merged 5 commits into from
May 19, 2015

Conversation

AndreLouisCaron
Copy link
Contributor

No description provided.

@AndreLouisCaron AndreLouisCaron mentioned this pull request May 16, 2015
Closed
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling a4740f0 on AndreLouisCaron:csr-encoding into 706d266 on pyca:master.

@alex
Copy link
Member

alex commented May 16, 2015

Jenkins, retest this please

1 similar comment
@alex
Copy link
Member

alex commented May 16, 2015

Jenkins, retest this please

@reaperhulk
Copy link
Member

This needs a rebase now :)

@AndreLouisCaron
Copy link
Contributor Author

@reaperhulk Rebase complete!

alex
alex reviewed May 18, 2015
View reviewed changes
src/cryptography/hazmat/backends/openssl/x509.py Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure I understand this comment.

@AndreLouisCaron
Copy link
Contributor Author

@alex @reaperhulk OpenSSL-specific CSR text prelude removed!

@reaperhulk reaperhulk added this to the Tenth Release milestone May 18, 2015
@reaperhulk
Copy link
Member

@AndreLouisCaron This is looking pretty good now. Would you mind adding an entry to the changelog that calls out the addition of public_bytes to the CSR class?

@AndreLouisCaron
Copy link
Contributor Author

@reaperhulk Sure, will do!

alex
alex reviewed May 18, 2015
View reviewed changes
tests/test_x509.py Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you name this test_public_bytes_pem so it's easier to search for.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

@alex
Copy link
Member

alex commented May 18, 2015

Can we add another test that asserts about the exact output, like we do for rsa: https://github.com/pyca/cryptography/blob/master/tests/hazmat/primitives/test_rsa.py#L1963-L1971

@alex
Copy link
Member

alex commented May 18, 2015

After that I think this is good to land

@AndreLouisCaron
Copy link
Contributor Author

@alex Done!

alex added a commit that referenced this pull request May 19, 2015
@alex
Merge pull request #1963 from AndreLouisCaron/csr-encoding
9acecae 
Adds support for writing CSRs.
@alex alex merged commit 9acecae into pyca:master May 19, 2015
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

x509

Milestone

Tenth Release

Development

Successfully merging this pull request may close these issues.

4 participants

@AndreLouisCaron @coveralls @alex @reaperhulk