Blowfish Support #201
Merged
Blowfish Support #201
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vectors sourced from https://www.schneier.com/code/vectors.txt but reformatted to comply with our NIST loader
There was a problem hiding this comment.
Make AES a link. Also should we make a weak ciphers section?
There was a problem hiding this comment.
A weak ciphers section makes sense. Blowfish (due to the key issue) & RC4 (when we add it) can obviously live there.
There was a problem hiding this comment.
Please don't use the name RC4, it's trademarked, refer to it as ARC4 or ARCFOUR instead.
(Yes this is a joke, but seriously quoting from wikipedia: "The name RC4 is trademarked, so RC4 is often referred to as ARCFOUR or ARC4 (meaning alleged RC4) to avoid trademark problems.")
|
vectors are good +1 |
joerichter-stash
pushed a commit
to kiwigrid/cryptography
that referenced
this pull request
Nov 15, 2017
Re-add deprecated support for unicode in a variety of APIs.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vectors sourced from https://www.schneier.com/code/vectors.txt but reformatted to comply with our NIST loader.
Depends on #198 and #199.
Refs #114