Skip to content

Conversation

reaperhulk
Copy link
Member

An experiment to fix #2021. Not sure if this is the right place to put the args yet.

@reaperhulk reaperhulk changed the title enable ASLR and NX on windows builds (affects 2.x only) [WIP] enable ASLR and NX on windows builds (affects 2.x only) Jun 17, 2015
@reaperhulk
Copy link
Member Author

This is blocked while gathering more info from the reporter in #2021.

@alex
Copy link
Member

alex commented Jun 17, 2015

retest this please

@reaperhulk reaperhulk changed the title [WIP] enable ASLR and NX on windows builds (affects 2.x only) enable ASLR and NX on windows builds (affects 2.x only) Jun 20, 2015
@reaperhulk
Copy link
Member Author

I have updated this PR and confirmed that the expected dynamic base and NX compatible attributes are present on Windows now.

@alex
Copy link
Member

alex commented Jun 20, 2015

git grep 'NXCOMPAT' and git grep 'DYNAMICBASE' don't have any results in a CPython checkout?

@alex
Copy link
Member

alex commented Jun 20, 2015

Ok, that's because this info is in some XML. That said, https://msdn.microsoft.com/en-us/library/ms235442.aspx and https://msdn.microsoft.com/en-us/library/bb384887.aspx indicate these are on by default?

@reaperhulk
Copy link
Member Author

@schlenk understands this far better than I do, but I believe these were not defaulted to on in 2008 (which is the compiler used for 2.6/2.7)

alex added a commit that referenced this pull request Jun 20, 2015
enable ASLR and NX on windows builds (affects 2.x only)
@alex alex merged commit 5e12f87 into pyca:master Jun 20, 2015
@reaperhulk reaperhulk deleted the windows-flags branch June 20, 2015 23:23
@schlenk
Copy link

schlenk commented Jun 21, 2015

Yes. The default is ON since Visual Studio 2010, OFF for Visual Studio 2008. So all the Python 2.7 modules don't have it, unless explicitly specified.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

ASLR and NX support on windows
3 participants