Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't use pipes #2334

Merged
merged 2 commits into from
Sep 10, 2015
Merged

Don't use pipes #2334

merged 2 commits into from
Sep 10, 2015

Conversation

alex
Copy link
Member

@alex alex commented Sep 10, 2015

Download the whole file first, @glyph points out that truncation attacks are a thing.

@alex
Don't use pipes
41aabcb 
Download the whole file first, @glyph points out that truncation attacks are a thing.
@alex
Merge branch 'master' into alex-patch-2
062b2a6
@codecov-io
Copy link

Current coverage is 99.98%

Merging #2334 into master will not affect coverage as of 062b2a6

@@            master   #2334   diff @@
======================================
  Files          115     115       
  Stmts        11957   11957       
  Branches      1334    1334       
  Methods          0       0       
======================================
  Hit          11955   11955       
  Partial          2       2       
  Missed           0       0

Review entire Coverage Diff as of 062b2a6

Powered by Codecov. Updated on successful CI builds.

reaperhulk added a commit that referenced this pull request Sep 10, 2015
@reaperhulk
Merge pull request #2334 from pyca/alex-patch-2
6aa52b2 
Don't use pipes
@reaperhulk reaperhulk merged commit 6aa52b2 into master Sep 10, 2015
@glyph
Copy link
Contributor

glyph commented Sep 10, 2015

✨

@alex alex deleted the alex-patch-2 branch September 10, 2015 11:12
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@alex @codecov-io @glyph @stevepeak @reaperhulk