Skip to content

Conversation

reaperhulk
Copy link
Member

Pulled from #2549

@mention-bot
Copy link

By analyzing the blame information on this pull request, we identified @public, @etrauschke and @AndreLouisCaron to be potential reviewers

@alex
Copy link
Member

alex commented Dec 23, 2015

lgtm, will merge when tests pass

@etrauschke
Copy link
Contributor

I guess it doesn't matter that the CRL doesn't contain any revoked certs?
Nit: Could have used the usual cryptography values for issuer info.

@alex
Copy link
Member

alex commented Dec 23, 2015

We don't have usual values, it varies based on what mood @reaperhulk is in
:-)

On Tue, Dec 22, 2015 at 7:41 PM, Erik Trauschke notifications@github.com
wrote:

I guess it doesn't matter that the CRL doesn't contain any revoked certs?
Nit: Could have used the usual cryptography values for issuer info.


Reply to this email directly or view it on GitHub
#2550 (comment).

"I disapprove of what you say, but I will defend to the death your right to
say it." -- Evelyn Beatrice Hall (summarizing Voltaire)
"The people's good is the highest law." -- Cicero
GPG Key fingerprint: 125F 5C67 DFE9 4084

@codecov-io
Copy link

Current coverage is 99.98%

Merging #2550 into master will not affect coverage as of 5b747fc

@@            master   #2550   diff @@
======================================
  Files          123     123       
  Stmts        13003   13003       
  Branches      1420    1420       
  Methods          0       0       
======================================
  Hit          13001   13001       
  Partial          2       2       
  Missed           0       0       

Review entire Coverage Diff as of 5b747fc

Powered by Codecov. Updated on successful CI builds.

alex added a commit that referenced this pull request Dec 23, 2015
@alex alex merged commit acb724e into pyca:master Dec 23, 2015
@reaperhulk reaperhulk deleted the crl-vector branch December 23, 2015 01:48
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 93df8b7 on reaperhulk:crl-vector into ** on pyca:master**.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

6 participants