-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Build our own 0.9.8 on travis #2553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This also removes several builds, can we make removing builds and switiching how we compile OpenSSL be two separate steps? |
51bfd3e
to
3bfe5ac
Compare
3bfe5ac
to
cd8875a
Compare
Current coverage is
|
Coverage problems are due to being newer than 0.9.8m, when we have some branches based on that. I'll drop us to 0.9.8l I guess (yuck). |
and 0.9.8l doesn't want to compile. going to let this one sit for a bit while I think about what to do... |
356af75
to
5dc50c0
Compare
same approach as in pyca#2553 for 0.9.8
same approach as in pyca#2553 for 0.9.8
same approach as in pyca#2553 for 0.9.8
.travis.yml
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add the letter here, in the event we want to add more in the future I don't want untangling this to be a pain.
Besides that comment this looks ok to me, but I'd like another pair of eyes because this is a little wild. Also, how long does compilation take? Keep in mind it will happen on the first push in any PR series. |
It adds about 2-3 minutes to the runtime of the job within the build. |
👍 |
.travis/install.sh
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unless there's a compelling reason can we drop the v
, it makes the logs hard to read.
This change looks OK To me, though I agree with the dropping of |
Changes Unknown when pulling 80b1281 on reaperhulk:098-change into ** on pyca:master**. |
This is an experiment to stop using the lucid hack and custom compile OpenSSL 0.9.8zh for coverage purposes on travis.