enable C traceback on memleak script #4890
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The commit message here is wrong. What it really does is give you python backtraces, even if the C one is disabled. Note that this probably slows the tests down by a lot. |
|
Do we want to have this additional detail available or just drop this? |
|
Dunno, This is always just for debugging, so I could go either way.
…On Sat, May 18, 2019 at 3:38 PM Paul Kehrer ***@***.***> wrote:
Do we want to have this additional detail available or just drop this?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#4890?email_source=notifications&email_token=AAAAGBGM2HETWWF3DLPHVJLPWBLNDA5CNFSM4HN2XXEKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODVWUWKI#issuecomment-493701929>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAAAGBFO4WVOLSVYRXG4PHDPWBLNDANCNFSM4HN2XXEA>
.
--
All that is necessary for evil to succeed is for good people to do nothing.
|
|
Meh whatever then. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split out from #4889