Add Encryption2021 serialization encryption type #6569
Conversation
``BestAvailableEncryption`` provides a curated selection of encryption algorithms that can change over time. While a curated selection is best for majority of users, some users in a LTS/Enterprise environment need more stability. I propose the addition of a curated and versioned selection of encryption types. Every time the algorithm selection of ``BestAvailableEncryption``, a new ``Encryption$VERSION`` is added. Once the algorithms of an old ``Encryption$VERSION`` are considered too weak (for some definition of "weak"), the type is deprecated. When the algorithm is broken, it is dropped. In practice this will happen very rarely. The current selection uses AES-256, which should be fine for the next decade(s). Signed-off-by: Christian Heimes <christian@python.org>
Signed-off-by: Christian Heimes <christian@python.org>
|
I am not a fan of this API, and before I'd be willing to consider it I need to hear the motivation fleshed out in more detail.
My other concern is future planning for what it would mean to update BestAvailableEncryption but not immediately need to remove 2021 for security issues. To me a scenario where we allowed these to diverge is a very "bug fixing is how you improve security" mindset, which I think is wrong (cf https://alexgaynor.net/2019/mar/07/chrome-windows-exploit-security-beyond-bugfixes/) -- security features and improvements are as important as bug fixes. Finally, the existing PEM encryption is awful, the KDF is terrible and it doesn't authenticate ciphertext. If there was a better option I'd want to switch to it immediately, but there isn't AFAIK. |
|
@tiran do you intend to revisit this or can we close? |
|
Closing, but if you want to discuss again feel free to reopen. |
BestAvailableEncryptionprovides a curated selection of encryptionalgorithms that can change over time. While a curated selection is best
for majority of users, some users in a LTS/Enterprise environment need
more stability.
I propose the addition of a curated and versioned selection of
encryption types. Every time the algorithm selection of
BestAvailableEncryption, a newEncryption$VERSIONis added. Oncethe algorithms of an old
Encryption$VERSIONare considered too weak(for some definition of "weak"), the type is deprecated. When the
algorithm is broken, it is dropped.
In practice this will happen very rarely. The current selection uses
AES-256.
Signed-off-by: Christian Heimes christian@python.org