Skip to content

Conversation

alex
Copy link
Member

@alex alex commented Aug 16, 2022

closes #7441

@alex alex force-pushed the configurable-serialization branch 3 times, most recently from ca1fe22 to db2b95c Compare August 16, 2022 22:56
@reaperhulk
Copy link
Member

enc_type = KeySerializationEncryptionBuilder().kdf_rounds(32).build(b"password") is the usage model then... And a more complex thing might look like:

KeySerializationEncryptionBuilder().mac_algorithm(SOME_ENUM).
    cipher(SOME_OTHER_ENUM).
    mac_rounds(100).
    kdf_rounds(300).
    build(b"password")

Do we have separate builders for types (e.g. PKCS12SerializationEncryptionBuilder)? Is SSH a distinct type? I think this approach is a reasonable one though.

@alex
Copy link
Member Author

alex commented Aug 20, 2022

I was going to just use the same type for each, and then have things check if the method was valid for that _format.

@alex alex force-pushed the configurable-serialization branch 3 times, most recently from ab7ed45 to a2496e4 Compare August 20, 2022 18:03
@alex alex marked this pull request as ready for review August 20, 2022 18:03
@alex alex changed the title PoC for making key serialization more configurable Initial APIs for making serialization encryption configurable Aug 20, 2022
@alex alex force-pushed the configurable-serialization branch 3 times, most recently from 2020949 to eef752e Compare August 21, 2022 15:21
@alex alex force-pushed the configurable-serialization branch 2 times, most recently from 5aae882 to c08c5c5 Compare August 22, 2022 02:51
@alex alex force-pushed the configurable-serialization branch from c08c5c5 to 9bb0160 Compare August 22, 2022 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants