Skip to content

Conversation

ekohl
Copy link
Contributor

@ekohl ekohl commented Jun 16, 2014

No description provided.

@lvh
Copy link
Member

lvh commented Jun 16, 2014

Thanks for your contribution! However, the markup is broken (double scheme: https://http://).

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 9ca5793 on ekohl:patch-1 into 06ddbf3 on pyca:master.

@ekohl
Copy link
Contributor Author

ekohl commented Jun 16, 2014

Sorry about that. I blame it on the early morning :)

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 99d1f9b on ekohl:patch-1 into 06ddbf3 on pyca:master.

@lvh
Copy link
Member

lvh commented Jun 16, 2014

LGTM! Thanks!

lvh added a commit that referenced this pull request Jun 16, 2014
Add link to documentation to README
@lvh lvh merged commit 1110bc9 into pyca:master Jun 16, 2014
@ekohl ekohl deleted the patch-1 branch June 16, 2014 09:15
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The URL is malformed. 😢

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm? Why's that? I'm guessing "the path is the empty string", but I thought at least RFC 3986 supported empty paths. I don't know if that's still current, or if maybe I misunderstand the RFC, or... Could you elaborate?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd be interested to know as well. Am I just relying on browser behavior that's less strict about the RFCs?

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants