Skip to content

Conversation

HYSUH
Copy link

@HYSUH HYSUH commented Aug 30, 2014

Improved the code that creates the server,client and CA certificates by adding comments and variables.

Note:This is my first pull request using github. So I apologize if I have done anything incorrectly.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling ab45a61 on HYSUH:improveExamples into 2739834 on pyca:master.

@hynek
Copy link
Contributor

hynek commented Apr 30, 2015

Hi, sorry for not coming back at your earlier. You’re on to something with some of the changes but some are covered by #245. Once #245 is merged, I’ll gladly revisit more possible enhancements with you on this PR.

@hynek
Copy link
Contributor

hynek commented May 6, 2015

Since #245 is merged now, feel free to work on improving the examples some more! They sure need it. :)

@hynek
Copy link
Contributor

hynek commented May 26, 2015

since this is not moving and not mergeable, I’m going to close it. please absolutely feel free to open a new and revised PR! thanks!

@hynek hynek closed this May 26, 2015
@HYSUH
Copy link
Author

HYSUH commented May 26, 2015

Sorry for not replying earlier. I will rework on a new PR. Thanks a lot!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants