Skip to content

Conversation

exarkun
Copy link
Member

@exarkun exarkun commented Dec 11, 2014

Add the missing implementation of check_privatekey. Fixes #178.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) when pulling 77b3d08 on exarkun:Context.check_privatekey into 7b31baf on pyca:master.

setup.py Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can require 0.7 now that it is released.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) when pulling 7cf3b47 on exarkun:Context.check_privatekey into 014c0cc on pyca:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) when pulling 7cf3b47 on exarkun:Context.check_privatekey into 014c0cc on pyca:master.

@exarkun
Copy link
Member Author

exarkun commented Jan 19, 2015

Self-review: approved.

exarkun pushed a commit that referenced this pull request Jan 19, 2015
Fix a regression in Context.check_privatekey which caused it to always succeed.
@exarkun exarkun merged commit 496f40d into pyca:master Jan 19, 2015
@exarkun exarkun deleted the Context.check_privatekey branch January 19, 2015 12:09
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

check_privatekey does not throw an exception for mismatching keys anymore

3 participants