Skip to content

Conversation

mhils
Copy link
Member

@mhils mhils commented Feb 28, 2015

Make the SSL_MODE_* constants first class citizens. (refs #190)

@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 94.52% when pulling eacafe3 on mhils:add_mode_consts into 496f40d on pyca:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 94.52% when pulling eacafe3 on mhils:add_mode_consts into 496f40d on pyca:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.03%) to 94.49% when pulling 30b31fe on mhils:add_mode_consts into 496f40d on pyca:master.

3 similar comments
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.03%) to 94.49% when pulling 30b31fe on mhils:add_mode_consts into 496f40d on pyca:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.03%) to 94.49% when pulling 30b31fe on mhils:add_mode_consts into 496f40d on pyca:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.03%) to 94.49% when pulling 30b31fe on mhils:add_mode_consts into 496f40d on pyca:master.

@exarkun
Copy link
Member

exarkun commented Mar 15, 2015

Thanks. PARTIAL_WRITE is required to make the existing test suite pass - so the part of this change covering that constant is tested (because OpenSSL.test.test_ssl.MemoryBIOTests.test_outgoingOverflow fails if you get that value wrong).

Do you think you could add some additional tests for the other constants here, demonstrating that the desired behavior can be achieved by using them?

Thanks. Please re-open the PR when that's done.

@exarkun exarkun closed this Mar 15, 2015
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Development

Successfully merging this pull request may close these issues.

3 participants