Do not litter working dir

[hynek]

This PR cleans up the handling of temporary files such that the CWD is not filled with them.

It changes the approach to creating a directory which it kills afterwards instead of keeping track of single files.

Some adjacent lines have been also cleaned up.

No code except tests is touched by this PR.

[coveralls]

Coverage increased (+0.07%) to 95.28% when pulling 46aed85 on hynek:do-not-litter-working-dir into cf7ede8 on pyca:master.

[coveralls]

Coverage increased (+0.07%) to 95.28% when pulling 46aed85 on hynek:do-not-litter-working-dir into cf7ede8 on pyca:master.

[coveralls]

Coverage increased (+0.07%) to 95.28% when pulling 46aed85 on hynek:do-not-litter-working-dir into cf7ede8 on pyca:master.

[coveralls]

Coverage increased (+0.07%) to 95.28% when pulling 2956601 on hynek:do-not-litter-working-dir into cf7ede8 on pyca:master.

[coveralls]

Coverage increased (+0.07%) to 95.28% when pulling 2956601 on hynek:do-not-litter-working-dir into cf7ede8 on pyca:master.

[coveralls]

Coverage increased (+0.07%) to 95.28% when pulling 2956601 on hynek:do-not-litter-working-dir into cf7ede8 on pyca:master.

[coveralls]

Coverage increased (+0.07%) to 95.28% when pulling 2956601 on hynek:do-not-litter-working-dir into cf7ede8 on pyca:master.

[hynek]

One thing I would suggest is to add the snowman unconditionally to all tmp files to simplify the code some more.

[coveralls]

Coverage increased (+0.07%) to 95.28% when pulling dda3ea8 on hynek:do-not-litter-working-dir into cf7ede8 on pyca:master.

[coveralls]

Coverage increased (+0.07%) to 95.28% when pulling dda3ea8 on hynek:do-not-litter-working-dir into cf7ede8 on pyca:master.

[coveralls]

Coverage decreased (-2.28%) to 92.93% when pulling c57dd68 on hynek:do-not-litter-working-dir into cf7ede8 on pyca:master.

[coveralls]

Coverage decreased (-2.28%) to 92.93% when pulling c57dd68 on hynek:do-not-litter-working-dir into cf7ede8 on pyca:master.

[coveralls]

Coverage decreased (-2.28%) to 92.93% when pulling c57dd68 on hynek:do-not-litter-working-dir into cf7ede8 on pyca:master.

[coveralls]

Coverage decreased (-2.28%) to 92.93% when pulling c57dd68 on hynek:do-not-litter-working-dir into cf7ede8 on pyca:master.

[coveralls]

Coverage decreased (-0.47%) to 94.74% when pulling f75553d on hynek:do-not-litter-working-dir into cf7ede8 on pyca:master.

[coveralls]

Coverage decreased (-0.47%) to 94.74% when pulling f75553d on hynek:do-not-litter-working-dir into cf7ede8 on pyca:master.

[coveralls]

Coverage decreased (-0.47%) to 94.74% when pulling f75553d on hynek:do-not-litter-working-dir into cf7ede8 on pyca:master.

[coveralls]

Coverage decreased (-2.64%) to 92.57% when pulling f75553d on hynek:do-not-litter-working-dir into cf7ede8 on pyca:master.

[coveralls]

Coverage decreased (-3.37%) to 91.83% when pulling f75553d on hynek:do-not-litter-working-dir into cf7ede8 on pyca:master.

[coveralls]

Coverage decreased (-2.26%) to 92.95% when pulling 4813c0e on hynek:do-not-litter-working-dir into cf7ede8 on pyca:master.

[coveralls]

Coverage decreased (-2.26%) to 92.95% when pulling 4813c0e on hynek:do-not-litter-working-dir into cf7ede8 on pyca:master.

[coveralls]

Coverage increased (+0.09%) to 95.3% when pulling 4813c0e on hynek:do-not-litter-working-dir into cf7ede8 on pyca:master.

[coveralls]

Coverage decreased (-2.62%) to 92.59% when pulling 1902c01 on hynek:do-not-litter-working-dir into cf7ede8 on pyca:master.

[coveralls]

Coverage increased (+0.09%) to 95.3% when pulling e90680f on hynek:do-not-litter-working-dir into cf7ede8 on pyca:master.

[hynek]

I’ve simplified a bunch, r4r!

[reaperhulk]

LGTM. The way SSL_CTX_load_verify_locations works is terrible. I haven't dug deeply yet but I bet there's a way to do that without requiring files on disk.

[reaperhulk]

(But that is an issue for a future PR)