Skip to content

Add del_extension needed by Zorp #246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Add del_extension needed by Zorp #246

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions OpenSSL/crypto.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1340,6 +1340,19 @@ def get_extension(self, index):
extension = _lib.X509_EXTENSION_dup(ext._extension)
ext._extension = _ffi.gc(extension, _lib.X509_EXTENSION_free)
return ext

def del_extension(self, index):
"""
Delete a specific extension of the certificate by index.

:param index: The index of the extension to delete.
:return: The X509Extension object deleted at the specified index.
"""
ext = X509Extension.__new__(X509Extension)
ext._extension = _lib.X509_delete_ext(self._x509, index)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will leak memory. It needs to use X509_EXTENSION_free in conjunction with ffi.gc. Take a look at the method right above this for an example.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, really! Thanks for pointing that out.

if ext._extension == _ffi.NULL:
raise IndexError("extension index out of bounds")
return ext

X509Type = X509

Expand Down