-
Notifications
You must be signed in to change notification settings - Fork 422
Expose some CRL attributes (#181) #264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This commit exposes some useful attributes of CRL objects: * Issuer * Last Update * Next Update * CRL extensions
3 similar comments
Setting some of these attributes available in #281 |
Since I’m woefully uninformed about CRLs, I would like @reaperhulk to comment on this. |
Is there an update on the status of this pull request? This feature would be extremely useful for anyone using CRLs. |
First of all, please accept my sincere apologies for this PR not moving along as we’d like to. I’ve tried to come up with a long-term solution to the general x509 problem domain and would also welcome your feedback to this thread: https://mail.python.org/pipermail/cryptography-dev/2015-December/000539.html (please note that there’s already responses: https://mail.python.org/pipermail/cryptography-dev/2015-December/thread.html https://mail.python.org/pipermail/cryptography-dev/2016-January/thread.html ). I really hope this could be a way to loosen the guardian knot that the pyOpenSSL’s x509 layer currently presents to us maintainers and lightens the frustrations for contributors like you. |
@hynek: No apologies needed! Except for mine, for taking this long to answer, that is. I understand from @glyph's https://mail.python.org/pipermail/cryptography-dev/2015-December/000542.html and the other messages that pyOpenSSL should be eventually be deprecated, and we should all be using Cryptography. Is that correct? I'm fine with this, and I can already do that for my code (in fact I submitted this pull request because I was not aware of this). If my understanding is correct, I'm happy to close this pull request and switch to Cryptography entirely. What's your advice? And thanks a lot for taking the burden of maintaining pyOpenSSL, by the way! |
@carletes My personal opinion; pyOpenSSL is still definitely maintained, but if you can switch over to purely using Cryptography's X509 stuff, without using pyOpenSSL at all, you probably should. If you are implementing TLS, pyOpenSSL is still probably a better way to go for now. |
What is the status of this PR? I find this feature extremely useful |
Our general policy at this point is that if it's possible to do in cryptography developers should do it there (where we have more modern APIs and a more active community). Since this is possible to do in cryptography (you can even convert to a cryptography CRL object by using |
This pull request addresses #181, exposing some useful attributes of CRL objects: