Skip to content

Conversation

mrjefftang
Copy link
Contributor

@exarkun
Copy link
Member

exarkun commented Apr 17, 2014

Please add unit tests and documentation: https://github.com/pyca/pyopenssl/blob/master/CONTRIBUTING.rst

@mrjefftang
Copy link
Contributor Author

Made the changes you asked for.

I'm not quite sure if it makes sense adding another parameter, 'curve', to generate_key or to reuse the 'bits' parameter.

I stuck with adding another parameter with a default of None since the parameter types are different.

@sholsapp sholsapp mentioned this pull request Apr 19, 2014
@mrjefftang mrjefftang closed this Feb 17, 2015
@exarkun
Copy link
Member

exarkun commented Feb 17, 2015

Why is this closed?

@mrjefftang
Copy link
Contributor Author

I had to clear out my repository so the branch it referred to no longer existed.

Also I'm thinking there's probably a better way of going about this such as creating a subclass of PKey like ECPKey which just overrides the necessary methods.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Development

Successfully merging this pull request may close these issues.

2 participants