Skip to content

fix: CI release failed #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 18, 2021
Merged

fix: CI release failed #16

merged 1 commit into from
Jul 18, 2021

Conversation

ffyuanda
Copy link
Member

Fix: #15

Signed-off-by: ffyuanda 46557895+ffyuanda@users.noreply.github.com

@ffyuanda ffyuanda marked this pull request as draft July 18, 2021 02:34
@ffyuanda
Copy link
Member Author

Here is the successful test instance: https://pypi.org/project/casbin-postgresql-watcher-test/

@ffyuanda ffyuanda marked this pull request as ready for review July 18, 2021 03:19
@ffyuanda
Copy link
Member Author

@techoner @Zxilly plz review

@Zxilly
Copy link
Contributor

Zxilly commented Jul 18, 2021

@ffyuanda if you want to test publish, you should use test_pypi, but not the pypi.

@Zxilly
Copy link
Contributor

Zxilly commented Jul 18, 2021

And why this commit exist 45a12fb

@ffyuanda
Copy link
Member Author

@Zxilly yeah I should've done that, but I was lazy and the semantic-release-pypi plugin is default to publish on pypi instead of test_pypi, I will delete the test publish later.

@ffyuanda
Copy link
Member Author

And why this commit exist 45a12fb

@Zxilly I'm also trying to figure out why it is there

Signed-off-by: ffyuanda <46557895+ffyuanda@users.noreply.github.com>
@ffyuanda
Copy link
Member Author

@Zxilly it should be gone now

Copy link
Contributor

@Zxilly Zxilly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@hsluoyz hsluoyz merged commit 05ac07b into pycasbin:master Jul 18, 2021
@github-actions
Copy link

🎉 This PR is included in version 0.0.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Release CI failed
3 participants