Skip to content

LTE: add PSM #244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 25, 2020
Merged

LTE: add PSM #244

merged 2 commits into from
Mar 25, 2020

Conversation

peter-pycom
Copy link
Contributor

No description provided.

@peter-pycom
Copy link
Contributor Author

FW PR: https://github.com/pycom/Firmware-Development/pull/114

@peter-pycom peter-pycom requested a review from Xykon March 23, 2020 18:56
@jirkadev jirkadev self-requested a review March 24, 2020 09:49
jirkadev
jirkadev reviewed Mar 24, 2020
View reviewed changes
Copy link
Contributor

@jirkadev jirkadev left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jirkadev
jirkadev previously approved these changes Mar 24, 2020
View reviewed changes
@peter-pycom
Copy link
Contributor Author

spoke to Catalin, todo:

  • document psm() method
  • document all (even non-psm) params in init()
  • move example to examples section and elaborate on application. ie, sensor, wake up, long sleep, detach/reattach, power consumption, negotiation with network

@peter-pycom peter-pycom requested review from catalinio and removed request for Xykon March 25, 2020 12:37
catalinio
catalinio approved these changes Mar 25, 2020
View reviewed changes
Copy link
Contributor

@catalinio catalinio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All seems ok.

@catalinio catalinio merged commit 32e3ec7 into development-publish Mar 25, 2020
@peter-pycom peter-pycom deleted the lte_psm branch June 18, 2020 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
2 more reviewers

@catalinio catalinio catalinio approved these changes

@jirkadev jirkadev jirkadev left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@peter-pycom @jirkadev @catalinio