Skip to content

Allow compressing to stdout like gzip and pigz on the isal.igzip CLI. #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Feb 19, 2021

Conversation

rhpvorderman
Copy link
Collaborator

@rhpvorderman rhpvorderman commented Feb 17, 2021

Checklist

  • Pull request details were added to CHANGELOG.rst

This is necessary for implementing pycompression/xopen#48.

I added pytest tests for the CLI. The unittests copied from CPython worked well, but the python -m gzip behavior has some quirks that I removed from the python -m isal.igzip implementation. Also the unittests did not properly report the coverage.
I find that the pytest tests for the CLI interface are much cleaner as well.

@codecov
Copy link

codecov bot commented Feb 17, 2021

Codecov Report

Merging #38 (d1f440f) into develop (49d1a5c) will increase coverage by 6.77%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #38      +/-   ##
===========================================
+ Coverage    88.97%   95.74%   +6.77%     
===========================================
  Files            2        2              
  Lines          136      141       +5     
===========================================
+ Hits           121      135      +14     
+ Misses          15        6       -9     
Impacted Files Coverage Δ
src/isal/igzip.py 95.65% <100.00%> (+6.93%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 49d1a5c...d1f440f. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant