ENH: Add location parameter to read_gbq and to_gbq #185
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows queries to be run against datasets in the Tokyo region. Likewise, it enables loading dataframes into Tokyo datasets. The location parameter was added in 0.32.0, so this PR also updates the minimum google-cloud-bigquery version.
Collaborator
Author
|
Integration/System tests are running at |
Fix test to use private_key parameter so that it passes on Travis.
Collaborator
Author
|
Bah, conda is broken again. Probably because of namespace packages. I'll revert my change that updated the conda google-cloud-bigquery version and see if that fixes it. |
This was referenced Jun 8, 2018
max-sixty
reviewed
Jun 10, 2018
| FROM UNNEST(GENERATE_ARRAY(0,5,1)) as r | ||
| """.format(tokyo_dataset, table_id), | ||
| location='asia-northeast1').result() | ||
| return table_id |
max-sixty
approved these changes
Jun 10, 2018
Contributor
max-sixty
left a comment
max-sixty
left a comment
There was a problem hiding this comment.
And some nice clean ups too 🤗
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows queries to be run against datasets in the Tokyo region.
Likewise, it enables loading dataframes into Tokyo datasets.
The location parameter was added in 0.32.0, so this PR also updates the
minimum google-cloud-bigquery version.
Towards #177