-
Notifications
You must be signed in to change notification settings - Fork 121
add xarray and preliminary timeline #102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I think we need a commitment to drop by 2020 before it is a signing statement. I think a close on the discussion in the rep is needed before merging this. |
Thanks @mscuthbert, can do. We may also change the name of the release version that we're target ing for 2019 so standby here. |
site.js
Outdated
|
||
'xarray':[ | ||
{content: '0.x Series', start: '2014-05-11', end: '2018-12-31', py2:true}, | ||
{content: '1.x Series', start: '2019-01-01', end: '2022-12-31'} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shoyer - do you have a suggestion for replacing the 1.x Series
here?
@mscuthbert - I think we're all good here. |
I see the discussion on the xarray issue was resolved. Do you want me to merge this as is? cc @shoyer. |
site.js
Outdated
|
||
'xarray':[ | ||
{content: '0.x Series', start: '2014-05-11', end: '2018-12-31', py2:true}, | ||
{content: '2018.1.0', start: '2019-01-01', end: '2022-12-31'} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is 2018.1.0
supposed to be a version number? We don't know exactly which version our first release without Python 2 support will be yet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can add the logo without a timeline entry, if you like. I'm not a big fan of the timeline anyway - it's quickly getting too big, and it's already starting to get out of sync with reality (e.g. it looks like IPython 7 is out, which it isn't).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good, let's add the logo without a timeline.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
timeline removed.
_sections/30-projects.md
Outdated
@@ -14,6 +14,7 @@ These projects pledge to drop Python 2 support in or before 2020. | |||
- [Jupyter notebook](https://jupyter.org) | |||
- [NumPy](http://numpy.org) | |||
- [pandas](http://pandas.pydata.org/) | |||
- [xarray](http://xarray.pydata.org/) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We've generally tried to arrange projects by popularity, using Github stars as a rough proxy. So could we ask you to put this line just below sunpy, which has a similar number of stars to xarray.
I guess you were going next to pandas because of the similarity, which makes sense as well. But as I've already told a number of other people about this ordering, I don't want to play favourites. :-)
(Of course, not all projects are on Github, and some of them have probably got more popular since they were added, so this doesn't work very neatly...)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, I was looking at forks, not stars. Looking at stars, Xarray is just after Astropy.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, I had set it next to pandas due to subject proximity but I get the ordering scheme now and have adjusted it accordingly.
Great, thanks :-) |
Add xarray to list of projects sunsetting Python 2.
cc @maxim-lian @fujiisoup @fmaussion @shoyer @duncanwp @Zac-HD @gerritholl
xref: pydata/xarray#1830