-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added basic PEP 8 to .travis.yml and fixed currently reported issues. Fixes #147. #148
Conversation
@@ -6,7 +6,6 @@ | |||
from numpy.testing import assert_allclose | |||
|
|||
# local | |||
from ..shapes import * |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is probably incorrectly removed.
These are the only JS files that we wrote: https://github.com/pydy/pydy/tree/master/pydy/viz/static/js/dyviz The ones in |
@@ -1,5 +1,4 @@ | |||
from sympy import symbols | |||
from sympy.physics.mechanics import * |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Likely incorrect.
@jellysheep I've add a checklist to the top. Please review those items. Some may not be relevant to this PR because you aren't adding code. But once you complete those items, the reviewers will check them off. |
@moorepants Thanks. |
@jellysheep Ok, do the best you can on your application and do as much work as you can here before you leave. Good luck! |
@moorepants Sorry for the delay, I returned on sunday but was struck down with a cold for a few days. The removed (and the now checked) whitespaces and imports should be fine now, just leave a comment if something is missing. I watched the SymPy discussion about formatting PRs, but I think the above comments are ok as they are about PEP8 compliance of the whole codebase, not just minor cosmetic fixes. |
Looks good. Thanks for the contribution. |
Added basic PEP 8 to .travis.yml and fixed currently reported issues. Fixes #147.
Python and Javascript code is checked for trailing whitespaces and blank lines, unused imports and tab indentation.
Fixes #147
Checklist
commit message.
nosetests
) and on Travis CI.pylint, to check your code)
Notes.
follow deprecation cycles.)