Fix segfault from repr attempting to access attrs on uninitialized instance #520
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Segfaults on main, passes with patch. Co-authored-by: Aaron Z <40212329+aaronzo@users.noreply.github.com>
dschult
approved these changes
Apr 2, 2024
aaronzo
approved these changes
Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #519
IIUC
__init__already useshandle=Noneas an indicator that something may have gone wrong during initialization. This PR leverages this fact to avoid calling the low-levelgv.agnameofonself.handlewhenself.handle is None.@aaronzo the test and proposed fix are basically ripped right out of your suggestions in #519 so I went ahead and added you as a co-author - hopefully that's okay! Should any other corner-cases be added to the test suite to ensure this fix covers the full gamut?