Skip to content

Add __del__() for Executors #211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 7, 2023
Merged

Add __del__() for Executors #211

merged 4 commits into from
Nov 7, 2023

Conversation

@jan-janssen
Copy link
Member

@jan-janssen jan-janssen commented Nov 7, 2023

No description provided.

@jan-janssen
Copy link
Member Author

jan-janssen commented Nov 7, 2023

Still raising an error:

Exception ignored in: <function ExecutorBase.__del__ at 0x7f3597a3e840>
Traceback (most recent call last):
  File "/usr/share/miniconda3/envs/test/lib/python3.11/site-packages/pympipool/shared/executorbase.py", line 65, in __del__
    self.shutdown(wait=True)
  File "/usr/share/miniconda3/envs/test/lib/python3.11/site-packages/pympipool/shared/executorbase.py", line 56, in shutdown
    self._process.join()
  File "/usr/share/miniconda3/envs/test/lib/python3.11/site-packages/pympipool/shared/thread.py", line 31, in join
    raise self._exception
RuntimeError: 
.Exception ignored in: <function ExecutorBase.__del__ at 0x7f3597a3e840>
Traceback (most recent call last):
  File "/usr/share/miniconda3/envs/test/lib/python3.11/site-packages/pympipool/shared/executorbase.py", line 65, in __del__
    self.shutdown(wait=True)
  File "/usr/share/miniconda3/envs/test/lib/python3.11/site-packages/pympipool/shared/executorbase.py", line 56, in shutdown
    self._process.join()
  File "/usr/share/miniconda3/envs/test/lib/python3.11/site-packages/pympipool/shared/thread.py", line 31, in join
    raise self._exception
RuntimeError:

jan-janssen
jan-janssen commented Nov 7, 2023
View reviewed changes
@jan-janssen jan-janssen merged commit 0a4b1a6 into main Nov 7, 2023
@jan-janssen jan-janssen deleted the add_delete branch November 7, 2023 20:49
@jan-janssen jan-janssen mentioned this pull request Nov 7, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jan-janssen