Test on older version of OSX #241
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@jan-janssen this trick has been working perfectly in |
Member
|
I feel we might miss the point when the latest images get fixed. So I am wondering if we just want to add both the |
Member
Author
|
I would recommend doing latest as a separate cron job then, so it doesn't keep giving failures to the PRs |
I'll remove this once the test is behaving as expected. I just can't do the manual trigger on a workflow that's only on a branch
It worked just fine with the macos-11 tests, so there is nothing wrong with the workflow file.
Member
Author
|
@jan-janssen I added a weekly cron job to try the openmpi tests on macos-latest. In an intermediate state I had it run on: pull-request and with macos-11 and it worked perfectly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #191, it looks like the macos failures are fundamentally not our fault; ideally the runners would handle MPI nicely, but in the meantime I think it is preferable to test on an older version than not to test at all (not to mention much more convenient to not always be restarting tests).