-
Notifications
You must be signed in to change notification settings - Fork 3
Add type hints for input check #339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe changes in Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- pympipool/shared/inputcheck.py (4 hunks)
Additional comments not posted (11)
pympipool/shared/inputcheck.py (11)
6-6: Type hint added foroversubscribeparameter.
14-14: Type hint added forcommand_line_argument_lstparameter.
21-21: Type hint added forgpus_per_workerparameter.
31-31: Type hint added forthreads_per_coreparameter.
41-41: Type hint added forexecutorparameter.
48-48: Type hint added forfunctionparameter.
56-56: Type hint added forresource_dictparameter.
63-63: Type hint added forrefresh_rateparameter.
70-70: Type hint added forbackendparameter.
80-80: Type hint added forblock_allocationandinit_functionparameters.
85-85: Type hint added formax_coresandmax_workersparameters, and return type specified.
Summary by CodeRabbit