Add compatability with Windows yajl.dll
#16
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yajl built with default build settings yields yajl.dll, so make an attempt to load this. At the moment, the existing load structure has simply been duplicated to achieve this. This could be refactored into something cleaner.
To reduce code duplication introduced by adding windows support in commit 117166f. List of file names is generated using a list comprehension so that the unique windows file name can be appended. Consequently, the list of file names can be iterated over and two separate cases are not needed.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building Yajl with the default build settings on Windows the resultant library is
yajl.dll. I added an attempt to load this in load_yajl, then did a little refactoring to reduce code duplication.I did the addition and the refactoring in separate commits, so I'm happy to resubmit this pull request without the refactor if you don't like it.
Passes all tests on Linux (Debian). Doesn't pass tests on Windows but only due to line ending differences. I can get almost all to pass by playing with the encoding when loading the
.goldcases (except some with unusual characters such asescaped_bulgarian.json.gold).