Skip to content

Fix j2534 connection params #273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 5, 2025
Merged

Fix j2534 connection params #273

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d0dbb8a
Allow to set J2534 - protocol and bauderate in constructor
kirya-dev May 20, 2025
b0ba2c0
J2534 - Allow to receive frames with padding error flag
kirya-dev May 20, 2025
d4aa489
Try to fix import Protocol_ID under linux test
kirya-dev Jun 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 21 additions & 15 deletions udsoncan/connections.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -709,10 +709,10 @@ class J2534Connection(BaseConnection):
:type name: string
:param debug: This will enable windows debugging mode in the dll (see tactrix doc for additional information)
:type debug: boolean
:param args: Optional parameters list (Unused right now).
:type args: list
:param kwargs: Optional parameters dictionary Unused right now).
:type kwargs: dict
:param protocol: CAN protocol
:type protocol: Protocol_ID
:param baudrate: Operation bauderate
:type baudrate: int

"""

Expand All @@ -727,23 +727,29 @@ class J2534Connection(BaseConnection):
exit_requested: bool
opened: bool

def __init__(self, windll: str, rxid: int, txid: int, name: Optional[str] = None, debug: bool = False, *args, **kwargs):
def __init__(self,
windll: str,
rxid: int,
txid: int,
name: Optional[str] = None,
debug: bool = False,
protocol = None,
baudrate = 500000,
):
BaseConnection.__init__(self, name)

# Set up a J2534 interface using the DLL provided
try:
self.interface = J2534(windll=windll, rxid=rxid, txid=txid)
except FileNotFoundError:
raise RuntimeError('DLL not found')

# Set the protocol to ISO15765, Baud rate to 500000
self.protocol = Protocol_ID.ISO15765
self.baudrate = 500000
self.protocol = protocol if protocol else Protocol_ID.ISO15765
self.baudrate = baudrate
self.debug = debug

try:
# Set up a J2534 interface using the DLL provided
self.interface = J2534(windll=windll, rxid=rxid, txid=txid)

# Open the interface (connect to the DLL)
self.result, self.devID = self.interface.PassThruOpen()
except FileNotFoundError:
raise RuntimeError('DLL not found')
except OSError as e:
if e.errno in [0x16, 0xe06d7363]:
raise RuntimeError('J2534 Device busy')
Expand Down Expand Up @@ -771,7 +777,7 @@ def __init__(self, windll: str, rxid: int, txid: int, name: Optional[str] = None
self.log_last_operation("PassThruConnect", with_raise=True)

configs = SCONFIG_LIST([
(Ioctl_ID.DATA_RATE.value, 500000),
(Ioctl_ID.DATA_RATE.value, self.baudrate),
(Ioctl_ID.LOOPBACK.value, 0),
(Ioctl_ID.ISO15765_BS.value, 0x20),
(Ioctl_ID.ISO15765_STMIN.value, 0),
Expand Down
2 changes: 1 addition & 1 deletion udsoncan/j2534.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,7 +214,7 @@ def PassThruReadMsgs(self, ChannelID, protocol, pNumMsgs=1, Timeout=100):
result = dllPassThruReadMsgs(ChannelID, byref(pMsg), byref(pNumMsgs), c_ulong(Timeout))
if Error_ID(hex(result)) == Error_ID.ERR_BUFFER_EMPTY or pNumMsgs == 0:
return None, None, 0
elif pMsg.RxStatus == 0 or pMsg.RxStatus == 0x100:
elif pMsg.RxStatus in [0, 0x100, 0x110]:
return Error_ID(hex(result)), bytes(pMsg.Data[4:pMsg.DataSize]), pNumMsgs

def PassThruWriteMsgs(self, ChannelID, Data, protocol, pNumMsgs=1, Timeout=1000):
Expand Down