Skip to content

Replaced multinomial probability bounds test in logp #1462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 20, 2016
Merged

Replaced multinomial probability bounds test in logp #1462

merged 1 commit into from
Oct 20, 2016

Conversation

fonnesbeck
Copy link
Member

The isclose condition caused nan gradient values for at least one model. This alternative seems to work.

Closes #1435

springcoil
springcoil approved these changes Oct 20, 2016
View reviewed changes
Copy link
Contributor

@springcoil springcoil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems sensible - I was thinking it was something like that.

@springcoil springcoil merged commit 854a6ab into master Oct 20, 2016
@springcoil springcoil deleted the multinomial_dlogp branch October 20, 2016 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@springcoil springcoil springcoil approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Multinomial dlogpt produces nan - 3.0.rc2 Regression

2 participants

@fonnesbeck @springcoil