Remove verbose argument
#1518
Merged
Remove verbose argument
#1518
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fonnesbeck
approved these changes
Nov 10, 2016
|
I'm not worried about breaking the verbosity flag, as it was intended to be used interactively for debugging. |
|
Yes, I think this is a good change. No reason to have two mechanisms do the same thing. I'll assign to @taku-y to review and merge. |
|
It looks good to me. I'll merge. |
|
@ColCarroll I just went to make this change on a week-old version and was pleasantly surprised. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Came up on #1516, I removed the
verboseargument in favor of setting logging levels (so the end user can globally set the level to log at). @taku-y might take a look at the ADVI changes -- I swapped out printing fortqdmthere, and update the ELBO at the same rate using thetqdmapi.This is a breaking change! But it'll break early and loudly (as soon as
Modelis initialized). If we wanted to give some warning, I can leave theverboseargument inModelfor a while, and just raise a DeprecationWarning whenever it is set.