Add example for custom theano op #2583
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cool LGTM
…On 20 Sep 2017 14:35, "Adrian Seyboldt" ***@***.***> wrote:
We were missing an example for a custom theano op with a gradient. This
adds a section to the advanced theano section in the docs with an example
for an implicit function.
The implementation here isn't particularly fast, it could be improved by
writing this in C, but I think that would be another section :-)
------------------------------
You can view, comment on, or merge this pull request online at:
#2583
Commit Summary
- Add example from custom theano op
File Changes
- *M* docs/source/advanced_theano.rst
<https://github.com/pymc-devs/pymc3/pull/2583/files#diff-0> (116)
Patch Links:
- https://github.com/pymc-devs/pymc3/pull/2583.patch
- https://github.com/pymc-devs/pymc3/pull/2583.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#2583>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/AA8DiIysY-jURR-hgbcd02HXo60ZNGF5ks5skRSdgaJpZM4Pd4ON>
.
|
twiecki
reviewed
Sep 20, 2017
| thetamu = theta * mu | ||
| return [- g[0] * mu ** 2 / (1 + thetamu + tt.exp(-thetamu))] | ||
|
|
||
| If you value your sanity, always check that the gradient is ok:: |
|
This is great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were missing an example for a custom theano op with a gradient. This adds a section to the advanced theano section in the docs with an example for an implicit function.
The implementation here isn't particularly fast, it could be improved by writing this in C, but I think that would be another section :-)